markscarts Posted December 8, 2005 Share Posted December 8, 2005 It seems that the {VAL_SKIN} value is not being passed to all the templates. Example: @ http://allservico.com/skinTest/ 1. Button appears in Shopping Cart box as it should; code is <img src="skins/{VAL_SKIN}/styleImages/buttons/view.gif"> 2. Buttons do not appear in Sessions box as they should. Same coding syntax. When I check properties on the missing images, the path shows an empty space where {VAL_SKIN} should be passing the skin name value. Why is this, and how do I rectify it? -------------------- Edit for people just viewing this: You won't see the problem; I took another approach to coding it. Quote Link to comment Share on other sites More sharing options...
Guest aikdo Posted December 8, 2005 Share Posted December 8, 2005 It has to be defined in each PHP file... at present i think is is passed only to the shopping cart and to the index.tpl files... Passing such information into each of the other files will require adding soe PHP code to EVERY includes/boxes file and includes/content file that you want to use it in... If you still want to go ahead contact me Via PM and ill send the code you need to add... But if this is a skin intended for external use, i recomend using a css method instead, simply create a div with a random class... <div class="image1"></div> then in your style.css file add... .image1 { width:{image_width}; height:{image_height}; background: URL('../styleImages/imagename.jpg'); background-repeat: no-repeat; } That will create a div which will simply make the image look like its there... If this is for a button simply change it to .image1 a{ width:{image_width}; height:{image_height}; background: URL('../styleImages/imagename.jpg'); background-repeat: no-repeat; } and give the link a class of image1 Quote Link to comment Share on other sites More sharing options...
markscarts Posted December 8, 2005 Author Share Posted December 8, 2005 I suspected something such. Thanks for the info; I'll take a closer look. FWIW, I could easily add my login image, etc., to the language file in place of the language, too, but I am trying to stay out of the system files for simple skin developments. I can probably make a workaround through stylesheets similar to your suggestion, though I would have much preferred using the variable :wacko: Quote Link to comment Share on other sites More sharing options...
Guest aikdo Posted December 8, 2005 Share Posted December 8, 2005 Ill make it a sugestion to brooky that the {VAL_SKIN} Variable is included in all PHP files... save us all when we are creating amazing skins :wacko: Quote Link to comment Share on other sites More sharing options...
Guest estelle Posted December 8, 2005 Share Posted December 8, 2005 Is it possible to include it in index.php, or does it have to be included in each of the .inc files? Quote Link to comment Share on other sites More sharing options...
Guest aikdo Posted December 8, 2005 Share Posted December 8, 2005 its already included in index.php and also shopping_cart.inc.php but not in any of the other php files at present it needs to be added to all the inc files that you wish to use it with... for example to show an image in session.tpl then the code would need to be added to session.inc.php... I am created a bug fix for this at the moment... It is really as simple as adding 3 lines of PHP to each of the files but will mean easier skinning for us all... Quote Link to comment Share on other sites More sharing options...
markscarts Posted December 8, 2005 Author Share Posted December 8, 2005 I agree. I don't want to add that to my list of edits each time I upgrade the cart, that list is long enough. If Brooky will add it in response to your bug report, so much the better There are certain variables that should be available globally, and that is one that could be useful in many places :wacko: Quote Link to comment Share on other sites More sharing options...
Guest estelle Posted December 8, 2005 Share Posted December 8, 2005 There are certain variables that should be available globally, and that is one that could be useful in many placesĀ I agree :blink: Quote Link to comment Share on other sites More sharing options...
Guest aikdo Posted December 8, 2005 Share Posted December 8, 2005 Make a list of the other Template veriable you think should be available... ill apply them all to the bug fix then hopefuly Brooky will include it in the next CC version... Its even easier than i thought its 1 line that needs to be included in each file... that simple, but will make a masive improvement... Quote Link to comment Share on other sites More sharing options...
Guest aikdo Posted December 8, 2005 Share Posted December 8, 2005 Ok i have made a tutorial topic on how to make such edits HERE... Hope fully it will be pinned untill brooky hopefully includes it in the release of CC... Cross your fingers all skiners... Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.