Compat-Test.php Inaccurate

[Guest Brandon!]

I just realized that even though the compat-test page has a small error on it. When it tries to detect the version of gd, it anticipates a valid decimal for the version. My current version is 2.0.34, which is obviously not a valid decimal. I think that the preg_replace() that is used before the sprintf(%d) would be sufficient for script security.:

function detectGD() {

	if (extension_loaded('gd') && function_exists('gd_info')) {

		$gd = gd_info();

		$version = preg_replace('#[a-z\s]#i', '', $gd['GD Version']);

		return sprintf('%d', $version);

	}

	return false;

}

Becomes:

function detectGD() {

	if (extension_loaded('gd') && function_exists('gd_info')) {

		$gd = gd_info();

		return preg_replace('#[a-z\s]#i', '', $gd['GD Version']);

	}

	return false;

}

Just my $.02

[convict]

Thanks! Best to use the bug tracker for at http://bugs.cubecart.com, thank you.

[Guest]

Yeah, the problem arises because the newer installations of PHP5 report the GD version differently than old versions. So we've had to revise the reporting. I'm all about killing a lot of the sprintf() calls in the code.

:wacko: