Jump to content

Note about skin changes between versions


HA1
 Share

Recommended Posts

We've been trying to do a better job keeping up with updates as they become available.  The main deterrent is the fact that our site has a slightly modified skin that we need to manually change when making upgrades.

 

To that end, I was hoping to make the suggestion that release announcements (>like this) could include a note on whether or not the upgrade involved changes to skin files?  

 

There may be good reason why that detail is not noted.  But if all else is the same, it would be helpful just to have that information to save a little time for those of us who were foolish enough to deviate from the standard skins.  

 

Thanks for your consideration!

Link to comment
Share on other sites

"There may be good reason why that detail [about skin changes] is not noted."

 

None that I can determine. Although, no specifics are mentioned about any of what files have been changed. So I assume skin files have been changed and I either run a file compare against the skins folder, or look in the github.

 

From CC5213 to CC5214:

Copy these image files from /admin/skins/default/images/ to each skin's /images/common/ or, if no /common/, just /images/ folder:

0.png, 1.png

 

For every skin, /templates/main.php, find:

{$COPYRIGHT}

Add After:

<div style="display: none" id="val_skin_folder">{$SKIN_FOLDER}</div>
<div style="display: none" id="val_store_url">{$STORE_URL}</div>
{if !empty($SKIN_COMMON)}<div style="display: none" id="val_skin_common_images">{$SKIN_COMMON}</div>{/if}

In /skins/crosshatch/templates/content.product.php, line 64:

From:
<div>
To:
<div style="overflow:hidden;">

From CC5210 to CC5211:

/skins/ALL_SKINS/templates/content.receipt.php

From:
  {if $ANALYTICS}
  <!-- Google Analytics for e-commerce -->
  <script type="text/javascript">
      {literal}
      var _gaq = _gaq || [];
      _gaq.push(['_setAccount', '{/literal}{$GA_SUM.google_id}{literal}']);
      _gaq.push(['_trackPageview']);
      _gaq.push(['_addTrans',
        '{/literal}{$GA_SUM.cart_order_id}{literal}',           // order ID - required
        '{/literal}{$GA_SUM.store_name}{literal}',  // affiliation or store name
        '{/literal}{$GA_SUM.total}{literal}',          // total - required
        '{/literal}{$GA_SUM.total_tax}{literal}',           // tax
        '{/literal}{$GA_SUM.shipping}{literal}',              // shipping
        '{/literal}{$GA_SUM.town}{literal}',       // city
        '{/literal}{$GA_SUM.state}{literal}',     // state or province
        '{/literal}{$GA_SUM.country_iso}{literal}'             // country
      ]);
      {/literal}
    
       // add item might be called for every item in the shopping cart
       // where your ecommerce engine loops through each item in the cart and
       // prints out _addItem for each
      {foreach from=$GA_ITEMS item=item}
      {literal}
      _gaq.push(['_addItem',
        '{/literal}{$GA_SUM.cart_order_id}{literal}',           // order ID - required
        '{/literal}{$item.product_code}{literal}',           // SKU/code - required
        '{/literal}{$item.name}{literal}',        // product name
        '',   // category or variation
        '{/literal}{$item.price}{literal}',          // unit price - required
        '{/literal}{$item.quantity}{literal}'               // quantity - required
      ]);
      {/literal}
      {/foreach}
      {literal}
      _gaq.push(['_trackTrans']); //submits transaction to the Analytics servers
    
      (function() {
        var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
        ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
        var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
      })();
      {/literal}
  </script>
  {/if}
 
To:
  {if $ANALYTICS}
  <script>
    {literal}
    ga('require', 'ecommerce', 'ecommerce.js');
    ga('ecommerce:addTransaction', {
      'id': '{/literal}{$GA_SUM.cart_order_id}{literal}',
      'affiliation': '{/literal}{$GA_SUM.store_name}{literal}',
      'revenue': '{/literal}{$GA_SUM.total}{literal}',
      'shipping': '{/literal}{$GA_SUM.shipping}{literal}',
      'tax': '{/literal}{$GA_SUM.total_tax}{literal}'
    });
    {/literal}
    
    {foreach from=$GA_ITEMS item=item}
      {literal}
      ga('ecommerce:addItem', {
          'id': '{/literal}{$GA_SUM.cart_order_id}{literal}',
          'name': '{/literal}{$item.name}{literal}',
          'sku': '{/literal}{$item.product_code}{literal}',
          'category': '{/literal}{if isset($item.options)}{foreach from=$item.options item=option}{$option} {/foreach}{/if}{literal}',
          'price': '{/literal}{$item.price}{literal}',
          'quantity': '{/literal}{$item.quantity}{literal}'
        });
      {/literal}
    {/foreach}
    ga('ecommerce:send');
  </script>
  {/if}

/skins/ALL_SKINS/templates/main.php

From:
    {if $ANALYTICS}
    {literal}<script type="text/javascript">
      var _gaq = _gaq || [];
      _gaq.push(['_setAccount', '{/literal}{$ANALYTICS}{literal}']);
      _gaq.push(['_trackPageview']);
    
      (function() {
        var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
        ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
        var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
      })();
    
    </script>{/literal}
    {/if}
 
To:
    {if $ANALYTICS}
    {literal}<script>
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
(i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
})(window,document,'script','//www.google-analytics.com/analytics.js','ga');
ga('create', '{/literal}{$ANALYTICS}{literal}', 'auto');  // Replace with your property ID.
ga('send', 'pageview');
</script>{/literal}
    {/if}

 
From CC528 to CC5210:

/skins/ALL_SKINS/styles/common.css

Remove - may or may not be present:
.openid {
  height: 18px;
  line-height: 18px;
  padding: 2px 3px;
}
 
Remove:
#openid_identifier {
    background: url(../../../images/icons/openid.png) no-repeat;
    height: 15px;
    padding: 1px;
    text-indent: 17px;
    width: 250px;
}
 
Remove:
/*
tbody > tr {
  height: 50px;
}
tbody > tr > td {
  padding: 2px 3px;
}
*/

/skins/ALL_SKINS/templates/main.php

From:
<link rel="canonical" href="{$VAL_SELF}"/>
To:
<link rel="canonical" href="{$CANONICAL}"/>

/skins/crosshatch/templates/content.checkout.confirm.php

Line 84: Corrects for wrong lettercase of variable name
From:
      <label>&nbsp;</label><span><input type="checkbox" name="delivery_is_billing" id="delivery_is_billing" {$delivery_checked}/> {$LANG.address.delivery_is_billing}</span>
To:
      <label>&nbsp;</label><span><input type="checkbox" name="delivery_is_billing" id="delivery_is_billing" {$DELIVERY_CHECKED}/> {$LANG.address.delivery_is_billing}</span>

/skins/crosshatch/templates/content.profile.php

Corrects non-standard coding
From:
<div>
  <h2>{$LANG.account.your_details}</h2>
  <p>
    {$LANG.account.update_your_details}
  </p>
  <form action="{$VAL_SELF}" method="post">
    <fieldset>
      <div>
To:
<div>
  <form action="{$VAL_SELF}" method="post">
  <div>
  <h2>{$LANG.account.your_details}</h2>
  <p>
    {$LANG.account.update_your_details}
  </p>
    <fieldset>
      <div>

From:
    </fieldset>
    <h2>{$LANG.account.password_change}</h2>
    <p>
      {$LANG.account.update_your_password}
To:
    </fieldset>
  </div>
    <h2>{$LANG.account.password_change}</h2>
    <div>
    <p>
      {$LANG.account.update_your_password}

From:
      </div>
    </fieldset>
     {/if}
    <p>
      <input name="update" type="submit" value="{$LANG.common.update}" class="button_submit"/><input type="reset" value="{$LANG.common.reset}" class="button_submit"/>
    </p>
To:
      </div>
    </fieldset>
     {/if}
    </div>
    <p>
      <input name="update" type="submit" value="{$LANG.common.update}" class="button_submit"/><input type="reset" value="{$LANG.common.reset}" class="button_submit"/>
    </p>
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...