Jump to content

Archived

This topic is now archived and is closed to further replies.

fldavidallsop

Marketplace skin demo preview issue

Recommended Posts

Can someone take a look at the skin demo preview on the extension marketplace.

I have noticed that the JavaScript on our skin demo breaks when being viewed via the CubeCart marketplace preview (works fine everywhere else), this error seems to be in relation to the iframe which is being used for the demo preview window.

If you go to the direct link of the demo there are no console errors. If you do this via the marketplace preview link you get the attached errors.

I have also looked at this for a few other skins published by other developers and similar console errors occur.

On a side note but equally as important if you try the marketplace preview on an actual mobile device (rather than resizing your desktop browser) the media queries a lot of these skins are using aren't kicking in, again if you go to the direct URL to the skins they work fine. So marketplace customers aren't getting a true demo of the responsive functionality of the skins for sale.

If you need any further information please let me know.

Capture.PNG

Share this post


Link to post
Share on other sites

According to this Mozilla document, the value is SAMEORIGIN, but CC6 is sending SAME-ORIGIN.

I'm thinking that if this gets changed, showing CC6 sites in a frame won't be able to happen.

 

 

Share this post


Link to post
Share on other sites

This is correct. For security reasons CubeCart has a header on line 16 of the index.php file.

header('X-Frame-Options: SAME-ORIGIN'); // do not allow iframes

When I tested the preview feature on the marketplace I used our demo store which has the same top level domain so didn't encounter this problem. 

It will work if that line of code is removed. 

Share this post


Link to post
Share on other sites

×