Dirty Butter Posted January 10, 2017 Share Posted January 10, 2017 I've lost the shaded box below the Filemanager box on the Images tab of the Product Listing in admin. Everything seems to be there in products.index.php <div class="fm-container"> <div class="loading">{$LANG.common.loading} <i class="fa fa-spinner fa-spin fa-fw"></i></div> <div id="image" rel="1" class="fm-filelist"></div> <div class="master_image"> <span>{$LANG.catalogue.image_main}</span>:<br><br> <div id="master_image_block"> <img src="{$PRODUCT.master_image}" id="master_image_preview"><div id="preview_image"><img src="{$PRODUCT.master_image}"></div> </div> </div> </div> <div class="cc_dropzone"> <div class="dz-default dz-message"><span>{$LANG.filemanager.file_upload_note}</span></div> </div> <div id="cc_dropzone_url" style="display: none;">?_g=filemanager&product_id={$PRODUCT.product_id}</div> <div id="val_product_id" style="display: none;">{$PRODUCT.product_id}</div> <div id="val_lang_go" style="display: none;">{$LANG.common.go}</div> <div id="val_lang_preview" style="display: none;">{$LANG.common.preview}</div> <div id="val_lang_main_image" style="display: none;">{$LANG.catalogue.image_main}</div> <div id="val_lang_show_assigned" style="display: none;">{$LANG.filemanager.show_assigned}</div> <div id="val_lang_show_all" style="display: none;">{$LANG.filemanager.show_all}</div> <div id="val_lang_folder_create" style="display: none;">{$LANG.filemanager.folder_create}:</div> <div id="val_lang_refresh_files" style="display: none;">{$LANG.filemanager.refresh_files}</div> <div id="val_lang_upload_destination" style="display: none;">{$LANG.filemanager.upload_destination}:</div> <div id="val_lang_enable" style="display: none;">{$LANG.common.enable}</div> <div id="val_lang_disable" style="display: none;">{$LANG.common.disable}</div> </div> I couldn't find anything in products.index.inc.php that obviously had to do with creating an upload image folder. Where should I look? Quote Link to comment Share on other sites More sharing options...
Claudia M Posted January 10, 2017 Share Posted January 10, 2017 That's one way I realized that my upgrade to 6.1.3 didn't take. I never had that shaded box. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 11, 2017 Author Share Posted January 11, 2017 I had already copied over all the latest js files and folders just in case that was the issue. That didn't fix the problem. I found I had not upgraded the admin/skins/default/styles/layout.css on one install. But the same thing happened to that install as had happened to the others: The upload shaded area shows the first time I access Image tab of a Product in admin. But when I refresh the page - it disappears! Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 15, 2017 Author Share Posted January 15, 2017 I've managed to get one of our stores to show the box, at least for now. I haven't dared refresh the page - as that's when it usually disappears. <div id="fm-actions"><div class="fm-create_folder">Create Folder:<input id="fm-icf" value="" type="text"><button type="button" id="fm-bcf">Go</button></div><div>Upload Destination: /<span id="val_subdir"></span></div><div class="fm-refresh"><i class="fa fa-refresh"></i>Refresh File List</div></div> Where is this code in the files? Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 15, 2017 Share Posted January 15, 2017 That HTML is built from the filetree javascript file, near line 214. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 15, 2017 Author Share Posted January 15, 2017 Thanks! I replaced ALL the js folder in admin and saw the upload box until I refreshed the page - then pouf - gone AGAIN! Something is just not stable, and I don't have a clue how to find it. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 15, 2017 Share Posted January 15, 2017 I see no reason for the "fm-actions" area (what you call the 'shaded upload box') to disappear from one page load to the next, other than javascript crashing. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 16, 2017 Author Share Posted January 16, 2017 The store that works properly is the dirtybutterestates.com one. All the images are in the source folder, not in subfolders. There are relatively few images - 122MB images vs 400MB with about 50 subfolders for the plushcatalog/test stores. Any suggestions about how to find out why this is happening? I tried adding {DEBUG} to the bottom of products.index.php, but don't know what to look for. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 16, 2017 Share Posted January 16, 2017 Firebug should show you if javascript has crashed. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 16, 2017 Author Share Posted January 16, 2017 I refreshed the page on plushcatalog 3 times and the box suddenly appeared. It took over 3 seconds for GET config.js?t=G14E to load. https://dirtybutter.com/plushcatalog/includes/ckeditor/config.js?t=G14E Refreshed it several more times, and it never shows the box again. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 16, 2017 Share Posted January 16, 2017 Any messages on Firebug's Console tab? Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 16, 2017 Author Share Posted January 16, 2017 None - sending a PM to you Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 19, 2017 Author Share Posted January 19, 2017 Thanks to Bsmither's kind help I now have an install on all three sites that is stable! This change to filetree javascript file works for me! Line 214: From: if(!$('#fm-actions').length) { To: if(!a(this).find('#fm-actions').length) { Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 21, 2017 Author Share Posted January 21, 2017 I spoke too soon I had my first occasion to open a subfolder to find the currently in use image and now it has double upload boxes. ugh! The extra box goes away when I leave the tab and doesn't seem to affect use of the filemanager functions - but it sure looks weird. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 22, 2017 Share Posted January 22, 2017 Ok, I think I got this solved. To experiment with this, implement the Github issues #1464 and #1463. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 22, 2017 Author Share Posted January 22, 2017 I'll work on this tomorrow. I have full confidence you will solve this! Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 23, 2017 Author Share Posted January 23, 2017 Sorry, but I'm getting confused. Am I supposed to KEEP this previous change and then make the edits from GitHub? On 1/19/2017 at 1:12 PM, Dirty Butter said: Line 214: From: if(!$('#fm-actions').length) { To: if(!a(this).find('#fm-actions').length) { Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 23, 2017 Share Posted January 23, 2017 1 hour ago, Dirty Butter said: Sorry, but I'm getting confused. Am I supposed to KEEP this previous change and then make the edits from GitHub? Line 214: From: if(!$('#fm-actions').length) { To: if(!a(this).find('#fm-actions').length) { The code changes suggested in the Github issue would be starting from stock CubeCart code. The Github discussion will never know about any of your personal changes already made. In other words, do not keep any prior edits to the code you have made that relate to this specific issue. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 23, 2017 Author Share Posted January 23, 2017 That's what I thought, but I'm getting the throbber - I'll check my code again. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted January 24, 2017 Share Posted January 24, 2017 Thanks both. From my testing all changes work work. I do recall seeing this issue on build. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 24, 2017 Author Share Posted January 24, 2017 I've upgraded the test site to today's commit (which has Bsmither's solution), and I still get the double upload box if I open an image subfolder. So some other modification of mine must be causing the issue. Will continue to fiddle with this. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 24, 2017 Share Posted January 24, 2017 (I'm sure you do this, but...) Be sure to force your browser to reload the page resources. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 24, 2017 Author Share Posted January 24, 2017 I do Does the Refresh in the shaded box work for you? I have to refresh the browser page to see the newly created folder. Quote Link to comment Share on other sites More sharing options...
bsmither Posted January 24, 2017 Share Posted January 24, 2017 Yes. But then, I have added more comments and code changes to those code edits already made in the Github. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted January 24, 2017 Author Share Posted January 24, 2017 I see your new GitHub reports - they seem to be related to the issues I'm still having. Always wiling to test fixes as best I can. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.