Jump to content

6.1.13


jka

Recommended Posts

The fix is not implemented with modifying the database class. Even though that is where the logic flaw exists, changing that would break too many other things. Instead the specific code that calls the database is changed by adjusting what gets sent to the database function.

See: https://github.com/cubecart/v6/commit/5ebea417da142530b558d18ef6132346de0d1cca

You may be able to just replace the User class.

Link to comment
Share on other sites

Regarding the changes in the CubeCart class file, forcing a string type cast on a variable that is already a string and seems to continue to be a string later on seems to be over-cautionary. However, I am not privy to the reasoning and decision making behind these particular changes.

Granted, there is absolutely no harm done by making these type casts.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...