keat Posted November 11, 2020 Share Posted November 11, 2020 Its that time of year where I work on a duplicate web site, making price chnages ready for 2021. Last year I complained of a delay between clicking the product and the price tab opening. (BSmither gave me a fix to open the price tab first) Then when it did open, I couldnt modify the price until the page had fully loaded. Enter new price, the pressing enter, took a second or so for the page to refresh. In total, changing one price took maybe 5 or 6 seconds. Not a long time being fair, however, when you've 1000's to do, and it takes you three weeks, you'll understand the frustration of waiting. Today, suffering the same fate, I decided to see if the browser was the issue. MS Edge is twice the speed. Link to comment Share on other sites More sharing options...
Retrodisco Posted November 11, 2020 Share Posted November 11, 2020 I cant get any tabs to open in the latest update with firefox, if you click a tab (say description or pricing), the url in the address bar changes but it does not 'go', you need to click on the address bar and press enter for it to work. Link to comment Share on other sites More sharing options...
bsmither Posted November 11, 2020 Share Posted November 11, 2020 If your browser has a Developer's set of features, please view its Javascript Console diagnostics page. There may be a clue posted there mentioning any problems that the javascript may be happening. (Switching among tabs on a page is javascript-powered.) Link to comment Share on other sites More sharing options...
NiteFox Posted November 11, 2020 Share Posted November 11, 2020 21 minutes ago, bsmither said: If your browser has a Developer's set of features, please view its Javascript Console diagnostics page. There may be a clue posted there mentioning any problems that the javascript may be happening. (Switching among tabs on a page is javascript-powered.) I've just noticed the tabbing issue. Seems when the cache is disabled it causes a JS issue "Uncaught TypeError: cannot read property 'split' of undefined " Related line admin.js 671 var ccp = cc.split("#"); Link to comment Share on other sites More sharing options...
bsmither Posted November 11, 2020 Share Posted November 11, 2020 There is a code change that I do not agree with: If the admin turns off caching, the "Clear Cache" button is not shown. In my opinion, there may be instances where clearing the cache would be necessary, even if it was disabled. (If I recall, disabling the cache does not clear it, switching to a new cache method does not clear either the losing or acquiring cache method, nor re-enabling the cache automatically clears it - common-sense housekeeping. So, I feel keeping the button visible is warranted.) When the button is suppressed from being shown, the node identifier, <li id="clear_cache_master", is not present in the HTML. Thus, the javascript is not able to locate this node and javascript basically quits. In the admin template common.breadcrumb.php, near line 10: Find: {if $CONFIG.cache}<li id="clear_cache_master"{if $CLEAR_CACHE} class="clear"{/if}><a href="{$SKIN_VARS.clear_cache_link}">{$LANG.maintain.cache_clear}</a></li>{/if} Change to: <li id="clear_cache_master"{if $CLEAR_CACHE} class="clear"{/if}><a href="{$SKIN_VARS.clear_cache_link}">{$LANG.maintain.cache_clear}</a></li> I've not tested this yet, as the javascript code that is looking for this node is new to CC641. Link to comment Share on other sites More sharing options...
Retrodisco Posted November 12, 2020 Share Posted November 12, 2020 On 11/11/2020 at 4:56 PM, NiteFox said: I've just noticed the tabbing issue. Seems when the cache is disabled it causes a JS issue "Uncaught TypeError: cannot read property 'split' of undefined " Related line admin.js 671 var ccp = cc.split("#"); Yes its this for sure. I have cache off and the tabs dont work. Link to comment Share on other sites More sharing options...
Al Brookbanks Posted November 13, 2020 Share Posted November 13, 2020 Sorry about this one guys. It was new code to reload the same tab when the cache was cleared. Maybe it wasn't tested with cache off. Do you think you can spend a moment to open a Github Issue? Link to comment Share on other sites More sharing options...
NiteFox Posted November 13, 2020 Share Posted November 13, 2020 1 hour ago, Al Brookbanks said: Sorry about this one guys. It was new code to reload the same tab when the cache was cleared. Maybe it wasn't tested with cache off. Do you think you can spend a moment to open a Github Issue? Opened an issue for you. Link to comment Share on other sites More sharing options...
Al Brookbanks Posted November 13, 2020 Share Posted November 13, 2020 Thank you Mr Fox. Link to comment Share on other sites More sharing options...
Recommended Posts
Archived
This topic is now archived and is closed to further replies.