Cookie Compliance Dialogue

Robo · November 11, 2020

the Cookie Compliance Dialogue stays on in the shop it does not go away www.rbckits.com

also the link in the banner to the privacy policy page does not work

Edited November 11, 2020 by Robo

Robo · November 12, 2020

nobody this problem after upgrading ?

bsmither · November 12, 2020

I am seeing the Kurouto skin. There is no cookie compliance dialog and the link to the Privacy Policy works.

Are you experimenting with the Foundation skin?

Robo · November 12, 2020

the cooky dialog is on top of the screen you can not click it away it stays there and the link in the coocky dialog does not work try it

i have no foundation skin used

btw i only did the upgrade and that worked fine , on some 404 s but that was solved quick and before the upgrade it worked all ok

Edited November 12, 2020 by Robo

bsmither · November 12, 2020

I must have been to your site a long time ago and accepted the cookies then. I found a cookie that said I will accept cookies, so I deleted that cookie. Now I see the banner.

I will try to find out why this is happening on your site.

bsmither · November 12, 2020

In admin, Documents, do you have a document listed where the radio button is checked in the Privacy column?

Robo · November 12, 2020

yes i did check that and put it to on (it was off) , but it does not change anything just get a bad request same as before

bsmither · November 12, 2020

This issue logged in the GitHub may be relevant: https://github.com/cubecart/v6/issues/2503

Foundation uses an AJAX request to inform CubeCart, but Kurouto uses a POSTed form.

Still looking into this.

Edited November 12, 2020 by bsmither

Robo · November 12, 2020

thanks hope to get it solved soon

bsmither · November 13, 2020

Two things to change: core code, and a skin template.

The core code:

In /classes/session.class.php, near line 583, find the public function set_cookie().

Find:
        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);

Change to:
        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        if (PHP_VERSION_ID < 70300) {
            return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
        } else {
            return setcookie($name, $value, [
              'expires' => $expire,
              'path' => $params['path'],
              'domain' => $params['domain'],
              'secure' => $params['secure'],
              'httponly' => $params['httponly'],
              'samesite' => (CC_SSL ? $params['samesite'] : ''),
            ]);
        }

I have submitted an issue in the Github.

The skin template:

Skins built for CC5 has a backwards incompatibility for a language string that was updated in CC6. CC6 provides a properly derived phrase. The template main.php, near the bottom:

Find:
    <p>{$LANG.notification.cookie_dialogue|replace:'%s':{$CONFIG.store_name}}</p>

Change to:
    <p>{$COOKIE_DIALOGUE_TEXT}</p>

Robo · November 13, 2020

the core changing did not work, it all quit error 500 does not laod anything

skin change .. now it loads the privacy document when clikking the link in the cooky banner

error report

[<strong>Exception</strong>] /home/u68474p65147/domains/rbckits.com/public_html/shop/classes/session.class.php:611 - syntax error, unexpected 'private' (T_PRIVATE)

Edited November 13, 2020 by Robo
error added

bsmither · November 13, 2020

What statement is on line 611 of /classes/session.class.php?

This what that area of session.class.php should look like after the edit. Make sure there are no missing curly braces.

              'samesite' => (CC_SSL ? $params['samesite'] : ''),
            ]);
        }
    }

    //=====[ Private ]=======================================

    /**
     * Close a session
     *
     * @return true
     */
    private function _close()

Edited November 13, 2020 by bsmither

Robo · November 13, 2020

wel replaced

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);
}
with

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
if (PHP_VERSION_ID < 70300) {
return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
} else {
return setcookie($name, $value, [
'expires' => $expire,
'path' => $params['path'],
'domain' => $params['domain'],
'secure' => $params['secure'],
'httponly' => $params['httponly'],
'samesite' => (CC_SSL ? $params['samesite'] : ''),
]);
}

and it did not work

bsmither · November 13, 2020

What you should be replacing is just two lines. Do NOT include the third line you have shown above (the closing curly brace).

Find:
        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);

Robo · November 14, 2020

we did exactly as given

In /classes/session.class.php, near line 583, find the public function set_cookie().

Find:
        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);

Change to:
        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        if (PHP_VERSION_ID < 70300) {
            return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
        } else {
            return setcookie($name, $value, [
              'expires' => $expire,
              'path' => $params['path'],
              'domain' => $params['domain'],
              'secure' => $params['secure'],
              'httponly' => $params['httponly'],
              'samesite' => (CC_SSL ? $params['samesite'] : ''),
            ]);
        }

please what ? should be replaced with what ?, as i do not understand , as this was posted by you and it is not clear for me , thanks anyway

bsmither · November 14, 2020

These two lines of code:

        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);

should be replaced by these 13 lines of code:

        $same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
        if (PHP_VERSION_ID < 70300) {
            return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
        } else {
            return setcookie($name, $value, [
              'expires' => $expire,
              'path' => $params['path'],
              'domain' => $params['domain'],
              'secure' => $params['secure'],
              'httponly' => $params['httponly'],
              'samesite' => (CC_SSL ? $params['samesite'] : ''),
            ]);
        }

Robo · November 14, 2020

that is what i did in the begin, but it is not working , will give it another try

Robo · November 14, 2020

again it does not work , in the admin site we get a 500 error all blank

what we did

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
return setcookie($name, $value, 'expires='.$expire.';path='.$params['path'].';domain='.$params['domain'].';secure='.$params['secure'].';httponly='.$params['httponly'].';'.$same_site);
}

replaced with

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
if (PHP_VERSION_ID < 70300) {
return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
} else {
return setcookie($name, $value, [
'expires' => $expire,
'path' => $params['path'],
'domain' => $params['domain'],
'secure' => $params['secure'],
'httponly' => $params['httponly'],
'samesite' => (CC_SSL ? $params['samesite'] : ''),
]);
}

bsmither · November 14, 2020

You are selecting three lines to be replaced:

A line that starts with $same_site...
A line that starts with return...
A line that has a closing curly brace }

Do NOT select the line that has the curly brace. Select only the two lines given in the instructions. Replace only those two lines.

Robo · November 14, 2020

maybe i am dumb

so these 2 lines

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
return setcookie($name, $value,

replace with

$same_site = CC_SSL ? 'samesite='.$params['samesite'] : '';
if (PHP_VERSION_ID < 70300) {
return setcookie($name, $value, $expire, $params['path']."; $samesite", $params['domain'], $params['secure'], $params['httponly']);
} else {
return setcookie($name, $value, [
'expires' => $expire,
'path' => $params['path'],
'domain' => $params['domain'],
'secure' => $params['secure'],
'httponly' => $params['httponly'],
'samesite' => (CC_SSL ? $params['samesite'] : ''),
]);
}

is this correct or ?? i do not understand as this is exact what you wrote in previuos post

bsmither · November 14, 2020

This is correct. Those 2 complete lines.

Robo · November 14, 2020

ok will give it a try let you know

Robo · November 15, 2020

yes it worked

thanks a lot

btw i have a lot of errors after upgrading like these ones any thougths ?

File: [seo.class.php] Line: [726] "INSERT INTO `CubeCart_seo_urls` (`type`,`item_id`,`path`,`custom`) VALUES ('prod','','-p.html','0');" - Duplicate entry '-p.html' for key 'PRIMARY'

bsmither · November 15, 2020

I am looking into that.

Cookie Compliance Dialogue

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation