Deprecated warning on a no longer supported plugin

[Dirty Butter]

Since SemperFi's plugins are no longer supported, I wonder if there is an easy way to fix what's causing this error message:

 	[<strong>Deprecated</strong>] /home/butter01/public_html/plushmemories.com/lovie-shoppe/modules/plugins/SFWS_Site_Testimonials/class.site_testimonials.php:163
- Unparenthesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e` or `a ? b : (c ? d : e)`
https://plushmemories.com/lovie-shoppe/1993-shari-lewis-wooly-lamb-chop-full-body-puppet-lc-shirt.html?item_group_id=PG_3713

Here's the popup from that message

mutingErrorHandler() (class.gui.session.list.php:4)
require_once() (class.gui.session.list.php:4)
include() (gui.class.php:1564)
_displaySessionBox() (gui.class.php:360)
displayCommon() (controller.index.inc.php:91)
include() (index.php:20)

 

[bsmither]

We would need to see that line from that file.

 

[Dirty Butter]

Sorry Brian - which file? class.gui.sessions.list.php, gui.class.php, controller.index.inc.php, index.php

[bsmither]

/modules/plugins/SFWS_Site_Testimonials/class.site_testimonials.php, line 163

 

[Dirty Butter]

$site_testimonials_display_data = (isset($_POST['site_testimonial'])) ? $_POST['site_testimonial'] : (isset($site_testimonials[0])) ? $site_testimonials[0] : '';

[bsmither]

I believe the edit should be as follows:

$site_testimonials_display_data = (isset($_POST['site_testimonial']))
  ? $_POST['site_testimonial']
  : ( (isset($site_testimonials[0])) ? $site_testimonials[0] : '' );

I broke the line into parts to more easily show the order of operations. The third line is evaluated first as it has the (newly added) parentheses. (You do not need to keep the line broken.)

[Dirty Butter]

Thank you Brian. I've replaced it and will see if that's the last of that warning. Sorry I was so dense on which file. I'm sure the addition of the popup helps you, but for me it's just gibberish that confuses the issue.