Empty Sale Items Category Still Shows

[Dirty Butter]

After leaving items as a per item sale item for a time I sometimes change the regular price to the sales price for items that did not sell. That means no items are on individual sale any more. But the Sales Items Category does not disappear when I make this change for all items on sale. Is that normal?

If so, is there any way to get rid of that Sale Items Category when it's not in use? It shows in both stores, the 5.1.4 and 5.1.5 one. Also, the 5.1.4 store has a current % off ALL items in progress, so it's silly to have the Sale Items Category when everything is on sale at the moment (nothing shows in the Sale Items category and obviously I would not want ALL of the items to show in that situation).

[bsmither]

The Sales Items category is still present, even though no items have a sale price. Is that normal?

Well, if that's how the store's Sale Mode is coded, then its normal. Is it the desired behavior from a store owner's point-of-view? Probably not.

If the sales mode is not in use, set the store's sale mode to Disabled. If the Sale Items category is still present in this mode, then there is a problem.

A hack could be devised to not include the Sale Items in the category list when the Sales Mode is "Global percentage discount".

[bsmither]

In the skin template file box.navigation.php, find:

{if $CTRL_SALE}

Change it to:

{if $CTRL_SALE == 1}

0 being Disabled, 1 being Per-Product, and 2 being Global Percentage Discount.

To suppress the display of the Sale Items sidebox when the sale mode is Global, in the file classes/gui.class.php, around line 970, find the _displaySaleItems() function. On the same line as the first occurrence of:

} elseif ... {

add after the open brace:

return false;

So that it looks like:

} elseif ($GLOBALS['config']....... { return false;

But if someone were to actually use a URL that represents the SaleItems category, CC will still display that category. All we have done here is to remove most store-front evidence of a global sale. Product prices will still have the sale styling and sale prices.

[Dirty Butter]

OK For Global % Discouont ==0 in box.navigation.php with the {return false: in gui.php worked perfectly. I had aready manually modified the sitemap.xml to not include sale_items, so I'm covered. PERFECT!!