System Error Log after upgrade from 6.08 to 6.09

[jpayam]

today i see lot of System Error Log after upgrade from 6.08 to 6.09:

    Today, 01:55    [Notice] /home/mystore/domains/mystore.com/public_html/admin/sources/settings.errorlog.inc.php:61 - Undefined variable: smarty_data
    Today, 01:55    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:926 - Undefined index: customer_id
    Today, 01:55    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:929 - Undefined index: customer_id
    Today, 01:54    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:926 - Undefined index: customer_id
    Today, 01:54    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:929 - Undefined index: customer_id
    Today, 01:54    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:926 - Undefined index: customer_id
    Today, 01:54    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:929 - Undefined index: customer_id
    Today, 01:54    [Notice] /home/mystore/domains/mystore.com/public_html/admin/sources/statistics.index.inc.php:268 - Undefined index: search_terms
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/admin/sources/settings.errorlog.inc.php:61 - Undefined variable: smarty_data
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Warning] /home/mystore/domains/mystore.com/public_html/classes/cache/cache.class.php:158 - unlink(/home/mystore/domains/mystore.com/public_html/cache/skin) [function.unlink.php]: Is a directory
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/includes/functions.inc.php:522 - Undefined index: X-Forwarded-For
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:926 - Undefined index: customer_id
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/classes/user.class.php:929 - Undefined index: customer_id
    Today, 01:53    [Notice] /home/mystore/domains/mystore.com/public_html/admin/sources/maintenance.index.inc.php:551 - Undefined variable: existing_backups

[bsmither]

Please ignore any Notices where there is an Undefined index or variable.

The Unlink Warning, in this case, can be ignored, but the programmers should really fix this.

[Dirty Butter]

What changed between 6.0.8 and 6.0.9 that is making these many hundreds of irrelevant Notices showing in the System Error Log? I'd like to revert to 6.0.8 for that code, but don't have a clue what to revert.

[bsmither]

You will want to revert /classes/debug.class.php. One of the edits in this class causes writing everything to the log.

[Dirty Butter]

OK THAT's BETTER!! I reverted all of debug.class.php to the 6.0.8 version. But can you tell me which ONE edit needs changing, without changing everything?

[bsmither]

The edits I recommend in CC608's Debug class are:

Near line 438:
From:

 if ($log) {
   $this->_writeErrorLog($error);
 }

To:

 if ($log) {
   $this->_writeErrorLog($error, $type);
 }

Near line 452:
From:

    $this->_errors[] = $message;
    $this->_writeErrorLog($message);

To:

    $this->_errors[] = $message;
    $this->_writeErrorLog($message, 'Exception');

Near line 602:
From:

  private function _writeErrorLog($message) {
    Database::getInstance()->insert('CubeCart_system_error_log', array('message' => $message, 'time' => time()));
  }

To:

  private function _writeErrorLog($message, $type) {
    if(isset($GLOBALS['db']) && $GLOBALS['db']->connected) {
      $GLOBALS['db']->insert('CubeCart_system_error_log', array('message' => $message, 'time' => time()));
    } elseif($type == 'Exception' || $type == E_PARSE) {
      echo $message;
    }
  }

 

[bondimedical]

https://github.com/cubecart/v6/issues/965