TYPO in v6 cubecart.class.php??

[Dirty Butter]

I discovered what appears to be a typo while attempting to merge my mod edits with cubecart.class.php:

// Display a search page
				$cart_oder_id = Order::validOrderId(trim($_GET['cart_order_id'])) ? trim($_GET['cart_order_id']) : '';
				$GLOBALS['smarty']->assign('ORDER_NUMBER', $cart_oder_id);
				$GLOBALS['gui']->addBreadcrumb($GLOBALS['language']->orders['search'], currentPage());
			}

Shouldn't $cart_oder_id be $cart_order_id???? Is there any other place that perhaps would have this same misspelling that needs fixing?

I found this same misspelling all the way as far as v6.0.

Edited December 28, 2015 by Dirty Butter

[bsmither]

That variable name is not used anywhere else in that function, so the way it is spelled will have no affect on any other code.

But well spotted!

[Dirty Butter]

Good to know it's not a real issue, but I'll report it on GitHub, if you haven't already.

[bsandall]

I see you are working on your Git skills, nice I do still plan on creating a good tutorial for that, but time, you know...

If you are on Windows, a handy trick to find all places in your code that certain string appers is to open a command window in your repository directory (shift-right-click the directory and select 'open command window') - once you've done that, you can do a search for 'cart_oder_id' or anything else using the Windows findstr command.

Since that page can be a little dense, this is what my typical command looks like:

findstr /i /s /n /c:"search_query" *.*

[Dirty Butter]

Thank you for the search command. That can certainly come in handy. I did already understand how to use the CC Git site, but had never tried to copy to my own Repository, etc. Sadly, as far as using SourceTree, I setup BeyondCompare as the Merge/Diff extra, as I have been using it a long time. I found it so much easier to deal straight with BC than to use the GIT process, that I gave up. Maybe the next time I play with it, it will make better sense to me.