keat Posted April 5, 2017 Share Posted April 5, 2017 On the foundation skin, pops up a lower banner giving the option to change the skin (we offer Kurouto for a V3 legacy look) However, if I click the cross to dismiss the banner, it comes back again when I change categories. Is there a way to supress this, it's annoying. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted April 5, 2017 Share Posted April 5, 2017 It can be turned off in the stores settings. Settings >> Layout >> "Allow users to change front-end skin?" Quote Link to comment Share on other sites More sharing options...
keat Posted April 5, 2017 Author Share Posted April 5, 2017 This would then disable the option to choose Kurouto. The site in question was V3 for many years, regular customer know thier way around the V3 site, hence the reason we offer Kurouto. Quote Link to comment Share on other sites More sharing options...
havenswift-hosting Posted April 5, 2017 Share Posted April 5, 2017 5 hours ago, keat said: However, if I click the cross to dismiss the banner, it comes back again when I change categories. Is there a way to supress this, it's annoying. Agreed ! I did report this as a github issue a long time ago but cannot find the original issue now - it may have been an original V5 issue Quote Link to comment Share on other sites More sharing options...
keat Posted April 6, 2017 Author Share Posted April 6, 2017 On skins such a Kurouto, the 'change skin' offer is small an unobtrusive, on Foundation, it's in your face and won't go away. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted April 6, 2017 Share Posted April 6, 2017 I have never offered skin changes to customers, so I'd never seen this issue before. I just played with your store, and I see what you mean. This definitely needs fixing. Maybe something session cookie related, like the site cookie acceptance message? @keat Please make a GitHub request on this. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted April 11, 2017 Share Posted April 11, 2017 https://github.com/cubecart/v6/issues/1580 Quote Link to comment Share on other sites More sharing options...
keat Posted April 18, 2017 Author Share Posted April 18, 2017 ta Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted May 4, 2017 Share Posted May 4, 2017 @keat This GitHub request has been closed without comment. Looks like you need a custom solution to solve it. Sorry. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted May 4, 2017 Share Posted May 4, 2017 No no no. It's closed with no milestone. This doesn't mean it won't be implemented. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted May 4, 2017 Share Posted May 4, 2017 Sorry - saw the closed and posted to keat before I saw your GitHuib explanation about all Feature Requests being "closed" but still available for further consideration. Quote Link to comment Share on other sites More sharing options...
keat Posted May 5, 2017 Author Share Posted May 5, 2017 I saw a few github requests closed yesterday. I assumed a clean up of some sort. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted May 5, 2017 Share Posted May 5, 2017 Yes someone pointed out that CubeCart looks badly managed/full of bugs on github due to the sheer volume of open issues. Most of these are in fact features request. The idea is to close them without milestone for future consideration. Once we start integrating we will assign a milestone and open. Quote Link to comment Share on other sites More sharing options...
keat Posted May 5, 2017 Author Share Posted May 5, 2017 I'm not sure how github works, but could you not have another tab for feature requests ? Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted May 5, 2017 Share Posted May 5, 2017 Unfortunately not. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted May 13, 2017 Share Posted May 13, 2017 @keat I've been testing SFWS's new Custom Foundation 5 Skin, and (thinking of you) I asked him to make the skin change selector less obtrusive. He has a choice now to move it to the sidebar. That looks MUCH better! Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted May 14, 2017 Share Posted May 14, 2017 You should be able to move the {include file='templates/box.skins.php'} to this div in main.php Foundation templates: <div class="large-3 columns show-for-large-up" id="sidebar_left"> {include file='templates/box.featured.php'} {include file='templates/box.popular.php'} {include file='templates/box.sale_items.php'} </div> You will probably have to look at the code in the box.featured, etc., to see how to get the skin change box to show up properly. Quote Link to comment Share on other sites More sharing options...
keat Posted May 15, 2017 Author Share Posted May 15, 2017 I'm not sure that I fully understand. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted May 15, 2017 Share Posted May 15, 2017 This seems to work for box.skins.php: {if $SKINS} <div class="panel" id="box-sale_items"> <form action="{$VAL_SELF}" method="post" class="autosubmit" id="box-skin"> <h4>Change Skin:</h4> <select name="select_skin" class="auto_submit"> {foreach from=$SKINS item=skin} {if isset($skin.styles)} {foreach from=$skin.styles item=style} <option value="{$skin.name}|{$style.directory}" {$style.selected}>{$skin.display} - {$style.name}</option> {/foreach} {else} <option value="{$skin.name}" {$skin.selected}>{$skin.display}</option> {/if} {/foreach} </select> </form> </div> {/if} Move the call for the skins box in main.php here (on right or change to make on left - depending on how your columns are setup): <div class="large-3 columns show-for-large-up" id="sidebar_right"> {include file='templates/box.featured.php'} {include file='templates/box.popular.php'} {include file='templates/box.sale_items.php'} {include file='templates/box.skins.php'} </div> Quote Link to comment Share on other sites More sharing options...
keat Posted May 16, 2017 Author Share Posted May 16, 2017 Now I understand. In the foundation, templates folder I changed box.skins.php to the code above and then added the string {include file='templates/box.skins.php'} to main.php. Although, this string already appears firther down the file, so I did initially end up with two 'change skin' boxes. This is much tidier. Thanks Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.