Dirty Butter Posted March 1, 2015 Share Posted March 1, 2015 I thought this was one of the logic flaws Foundation was supposed to fix. I've tried to find the file with the Payment Method choice code in it, with no luck. We only have one Gateway. As is, customer cannot check out without checking the payment method. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 1, 2015 Share Posted March 1, 2015 That's not Foundation's job. It is the gateway controller code's job. I think it is in cubecart.class.php. I'll look for it. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 1, 2015 Share Posted March 1, 2015 In cubecart.class.php, the _displayGateways() function, there is code that will auto jump to the single enabled gateway, unless any enabled gateway is loaded as a plugin, as opposed to a gateway. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 1, 2015 Share Posted March 1, 2015 Hm.. But I do see the gateway on Foundation. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 1, 2015 Share Posted March 1, 2015 There is a new function, CubeCart->_listPaymentOptions(). I have no idea why it's there. $GATEWAYS is collected with no checking similar to CubeCart->_displayGateways(). _listPaymentOptions() will probably eventually replace _displayGateways(). The skin is testing for $INCLUDE_CHECKOUT (false at Basket, true at Checkout) and !$DISABLE_GATEWAYS (not assigned anywhere, therefore true). Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 1, 2015 Author Share Posted March 1, 2015 So is a bug that needs to be reported? Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 1, 2015 Share Posted March 1, 2015 I would call it a feature not yet carried over from CC5. But, anyway, yeah. Quote Link to comment Share on other sites More sharing options...
havenswift-hosting Posted March 2, 2015 Share Posted March 2, 2015 Hi Github issue https://github.com/cubecart/v6/issues/299opened Ian Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted March 2, 2015 Share Posted March 2, 2015 If you have one payment gateway that is marked as default the only payment option will be checked with a radio button next to it. This was its more of an information reference than anything else. Whether it shows or not is debatable. Maybe if there is only one option and its not marked as default, it should forcefully be marked as default. Thats probably the best solution. Quote Link to comment Share on other sites More sharing options...
havenswift-hosting Posted March 2, 2015 Share Posted March 2, 2015 Hi Al I think the point is that if there is only one payment gateway, then the screen asking the customer to choose between a single option should not even be shown. CubeCart certainly always used to take customers directly into to the payment gateway in this circumstance Ian Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted March 2, 2015 Share Posted March 2, 2015 I completely get the point but if that single payment gateway is marked as default in the configuration it will be checked by default and it can essentially be ignored. That begs the question; 1. Should it show the one available payment method allowing them to make a decision before proceeding. 2. Should it surprise the customer with the one payment method on the next stage? Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 2, 2015 Author Share Posted March 2, 2015 I had not marked it as default. That done, perhaps the issue is the wording CHOOSE. I can change that from Language. The problem for me I think is realizing I need to check every screen, such as currency, after upgrade, and not assume v5 settings carried over. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted March 2, 2015 Share Posted March 2, 2015 I think the best solution is along the lines of; "If only gateway is not set as default make it so." Thanks for the gitHub report. Quote Link to comment Share on other sites More sharing options...
Al Brookbanks Posted March 2, 2015 Share Posted March 2, 2015 https://github.com/cubecart/v6/commit/805e89dd68ee4cf3ee71203322e471dc1f752017 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.