keat Posted March 7, 2017 Share Posted March 7, 2017 I have one of Semperfi's mods installed and am having a few issues with it. I suspect that Daren is otherwise engaged, as I've had no response from him recently. I'm seeing these logged in custom.ini.inc error log, which I guess are related. [07-Mar-2017 14:13:03 UTC] PHP Notice: Error: Hook 'category_product_options/hooks/class.cubecart.pre_display_category.php' was not found in /home/xxxx/public_html/classes/hookloader.class.php on line 280 line 280 reads " trigger_error("Error: Hook '".$hook['plugin'].'/'.$hook['filepath']."' was not found", E_USER_NOTICE); " While I await a response from Daren, could anyone help shed any light on this ? Quote Link to comment Share on other sites More sharing options...
Noodleman Posted March 7, 2017 Share Posted March 7, 2017 (edited) It's a havenswift module, and the error is from a hook which used to be there, but isn't anymore. You can manually delete the hook from the database, or disable it via "Manage hooks" in the admin area. If a hook is removed, CubeCart doesn't clean it up. Ideally CubeCart should check if a file exists before it tries to include it. If it doesn't exist, auto disable the hook Edited March 7, 2017 by Noodleman Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 Has this mod ever worked correctly for you? Did you goto the Hooks for this plugin and save the page? Quote Link to comment Share on other sites More sharing options...
keat Posted March 7, 2017 Author Share Posted March 7, 2017 Hi Noodleman, Its definately one of Darens. Although I did also demo Ians before making a descsion which way to go, so maybe it is left over from this. It's a bit in the air as to whether it worked correctly. I had the earlier version running on a test site, and from what I could gather was working OK. The new version was released a few weeks back which says it was tested with 6.1.5. I'd been putting the upgrade off for weeks, and I was in such a rush to get the site updated, I guess I never tested the plugin to it's full extent. Much like anything else, something alays gets over looked. Comapring the hooks folder between the old version and new, theres a subtle difference in the file name. Old version - class.cubecart.pre_display_category.php New Version - class.cubecart.display_category.php I've removed this from the dbs, lets see if the errors subside. Quote Link to comment Share on other sites More sharing options...
Noodleman Posted March 7, 2017 Share Posted March 7, 2017 that's odd, as the file name in your error belongs to a Havenswift module. it's possible you had it installed at one time then removed it and the hook is invalid. when you delete the module CubeCart doesn't actually remove the hooks. In this case it needs to be deleted from the database. CubeCart_hooks, find the one in question and remove it. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 2 minutes ago, Noodleman said: when you delete the module CubeCart doesn't actually remove the hooks. In this case it needs to be deleted from the database. CubeCart_hooks, find the one in question and remove it. Is this a bug that should be addressed in GitHub? Quote Link to comment Share on other sites More sharing options...
havenswift-hosting Posted March 7, 2017 Share Posted March 7, 2017 52 minutes ago, keat said: 07-Mar-2017 14:13:03 UTC] PHP Notice: Error: Hook 'category_product_options/hooks/class.cubecart.pre_display_category.php' was not found in /home/xxxx/public_html/classes/hookloader.class.php on line 280 That PHP Notice is 100% from our Category Product Options plugin but as Alec has said, it will not cause any problems at all. The issue is annoying as it fills up the error_log file but it wont be causing any issues and if you are no longer running that plugin and you are having problems with one of Daren's then that message is not related Quote Link to comment Share on other sites More sharing options...
keat Posted March 7, 2017 Author Share Posted March 7, 2017 It seems to have stopped since I removed it from the DBS. Ta Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 Started to mark this as Resolved, but then thought better of it. So does the mod issue still exist, or was it just the error message concerning you? Quote Link to comment Share on other sites More sharing options...
keat Posted March 7, 2017 Author Share Posted March 7, 2017 The issues i'm having with the mod still exist, but i'm now not convinced that this above error is related to the problems. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 OK - I have one plugin with Daren that he had to upgrade due to some change in 6.1.5 - something about Hash. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 7, 2017 Share Posted March 7, 2017 Please make this investigation: 1. Is the extension /category_product_options/ folder still in the /modules/plugins/ folder? 2. If so, look at the contents of the config.xml file in that folder. 3. Is there any mention of the class.cubecart.pre_display_category.php hook and/or the class.cubecart.display_category.php hook? 4. Which of these hooks are actually present in the extension's /hooks/ folder? Quote Link to comment Share on other sites More sharing options...
keat Posted March 7, 2017 Author Share Posted March 7, 2017 The folder category_product_options no longer exists in the plugins folder. And the present hook is class.cubecart.display_category. I do see class.cubecart.pre_display_category.php in plugins/hooks.xml Is it OK to stay or should it be removed ? Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 Seems reasonable to remove it, or at least comment it out for now. Bad advice corrected by Bsmither's comment further down. Quote Link to comment Share on other sites More sharing options...
keat Posted March 7, 2017 Author Share Posted March 7, 2017 I'll comment it out for now. Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted March 7, 2017 Share Posted March 7, 2017 I've found whole tables in our database from old mods going way back that haven't been in use since earlier versions of CC. It would be great if each plugin came with a way to completely remove its code if so desired. Of course that's probably not going to happen and more than likely impossible with hard coded mods. More in the realm of possibility might be a Cleaner plugin of some kind to test all code/tables and list as not in use in some way - a pipe dream I fear, but sure would be nice. Quote Link to comment Share on other sites More sharing options...
bsmither Posted March 7, 2017 Share Posted March 7, 2017 This file, plugins/hooks.xml, is informational and is used to populate the drop-down selector when creating a new Code Snippet. Please do not edit this file. Quote Link to comment Share on other sites More sharing options...
Noodleman Posted April 3, 2017 Share Posted April 3, 2017 (edited) On 07/03/2017 at 3:14 PM, Dirty Butter said: Is this a bug that should be addressed in GitHub? I don't think it's a bug since there isn't anything to clean it up at the moment, so it would be an improvement. https://github.com/cubecart/v6/issues/1569 Edited April 3, 2017 by Noodleman Quote Link to comment Share on other sites More sharing options...
Dirty Butter Posted April 27, 2017 Share Posted April 27, 2017 On 3/7/2017 at 8:27 AM, keat said: I have one of Semperfi's mods installed and am having a few issues with it. I suspect that Daren is otherwise engaged, as I've had no response from him recently. Sorry I didn't find this sooner: https://www.semperfiwebservices.com/easter-2017.html Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.